[FEATURE] Support arithmetic operators in CSS functions#607
Conversation
This is the enhancement from #390.
oliverklee
left a comment
There was a problem hiding this comment.
Looks good all in all. Only one nitpick.
oliverklee
left a comment
There was a problem hiding this comment.
LGTM. Thanks for picking this up! ❤️
oliverklee
left a comment
There was a problem hiding this comment.
Ah, no, stop the press: We still need a changelog entry for this new feature.
|
I've added strict types declaration to the new (test) source file. @sabberworm, can you give this a quick look to confirm you think it's OK for now. Longer term, I think it would be cleaner to introduce a There is calling for a release with this in ASAP, at least as far as CSS3, hence I think this interim solution will suffice, as full CSS4 support may take some time and effort. |
- Correct nomenclature in datum name for numeric part of `length`.
Indeed we do. It's lack was a deliberate alertness test ;) Also corrected nomenclature of the numeric part of a length value (MDN calls it a 'number' not a 'value'). |
`calc` was already supported.
|
I've updated this again. I noted that arithmetic in |
Just re-spotted that #389 seeks to do just that. Though it is a PR on top of a PR, so may be somewhat awkward to unravel. |
Yes, absolutely. I'd also like to check our class naming and structure against the terms and concepts used in the the official specification. |
I'm finding a very close if not exact match there. Kudos to @sabberworm. But, yes, please do review. |
Looking at that, the new |
… but not as part of this PR. :-) |
This is the enhancement from #390. `calc` was already supported.
This is the enhancement from #390. `calc` was already supported.
This is the enhancement from #390.